Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling of predefined variable ${workspaceFolderBasename} #642

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Add handling of predefined variable ${workspaceFolderBasename} #642

merged 2 commits into from
Jun 23, 2024

Conversation

yerseg
Copy link
Contributor

@yerseg yerseg commented Jun 20, 2024

It's useful in my scenario when I'm creating a build dir that name depends on the name of workspace

HighCommander4
HighCommander4 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@HighCommander4 HighCommander4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing!

HighCommander4
HighCommander4 requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@HighCommander4 HighCommander4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a clang-format failure (I think just trailing whitespace after the &&), could you fix it please?

@HighCommander4 HighCommander4 mentioned this pull request Jun 21, 2024
Closed
@yerseg
Copy link
Contributor Author

yerseg commented Jun 21, 2024 •
edited
Loading

@HighCommander4 fixed formatting, thank you

@yerseg yerseg requested a review from HighCommander4 June 21, 2024 20:13
@HighCommander4 HighCommander4 merged commit 37ba1e9 into clangd:master Jun 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HighCommander4 HighCommander4 HighCommander4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yerseg @HighCommander4