Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compression, better emitter /w tests #4

Closed
wants to merge 4 commits into from

Conversation

Zwork101
Copy link

Pull Request Template

Please try to complete the below as best as possible. Some of the fields
may not be necessary so feel free to add or edit as you see fit.

Checklist

Confirm you have completed the following actions prior to submitting this PR.

  • There is an existing issue report for this PR. (Existing PR)
  • I have forked this project.
  • I have created a feature branch.
  • My changes have been committed.
  • I have pushed my changes to the branch.

Title

Added compression as an option, created a fully documented, better emitter, and created tests for said emitter.

Description

Decompression was changed so that this time we create a decompression object, and use it repeatedly to decompress information. A new emitter was added that supports priority, a bit more efficient and is documented. Lastly created tests for the the created emitter.

Issue Resolution

Doesn't fix, just enhances

This Pull Request fixes #3

New or Changed Features

  • Added decompression support
  • New event emitter
  • event emitter tests

Copy link
Member

@Not-Nik Not-Nik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Just some minor changes/additions required to merge.

clamor/gateway/connector.py Outdated Show resolved Hide resolved
clamor/gateway/emitter.py Outdated Show resolved Hide resolved
clamor/gateway/connector.py Show resolved Hide resolved
@Zwork101
Copy link
Author

NO NOT MERGE: Still a bug with the gateway reconnect test that needs to be resolved.

@Not-Nik
Copy link
Member

Not-Nik commented Jul 23, 2019

Ok, thanks for your effort. Just hit me up on Discord when this is ready to merge

clamor/gateway/emitter.py Outdated Show resolved Hide resolved
Copy link
Author

@Zwork101 Zwork101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In total, added and implemented an emitter. Fixed a test, one test is still failing, but that's unrelated to the emitter.

@vbe0201 vbe0201 added the rebase This pull request was merged by rebase label Aug 2, 2019
@vbe0201 vbe0201 closed this Aug 2, 2019
@vbe0201 vbe0201 added component: gateway Issues or Pull Requests addressing the gateway component enhancement New feature or request labels Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: gateway Issues or Pull Requests addressing the gateway component enhancement New feature or request rebase This pull request was merged by rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants