-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added compression, better emitter /w tests #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Just some minor changes/additions required to merge.
NO NOT MERGE: Still a bug with the gateway reconnect test that needs to be resolved. |
Ok, thanks for your effort. Just hit me up on Discord when this is ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In total, added and implemented an emitter. Fixed a test, one test is still failing, but that's unrelated to the emitter.
Pull Request Template
Please try to complete the below as best as possible. Some of the fields
may not be necessary so feel free to add or edit as you see fit.
Checklist
Confirm you have completed the following actions prior to submitting this PR.
Title
Added compression as an option, created a fully documented, better emitter, and created tests for said emitter.
Description
Decompression was changed so that this time we create a decompression object, and use it repeatedly to decompress information. A new emitter was added that supports priority, a bit more efficient and is documented. Lastly created tests for the the created emitter.
Issue Resolution
Doesn't fix, just enhances
This Pull Request fixes #3
New or Changed Features