scrape search key for every request #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid
added a commit
to xavdid/howlongtobeat
that referenced
this pull request
Aug 30, 2024
mostly a copy of ckatzorke#64, plus a typescript upgrade
|
I copied your PR for my fork, thank you for that! FWIW, you can load the API key lazily rather than on every request (if you store it on the class): xavdid@5375d74#diff-1af9a3390b92891b019f2dbae92c77ca7d05282003849d5642715613e809ab54R89 |
|
i used your forks for a while but this doesnt seem to work anymore so i guess this PR needs some updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #63 the search url changed.
It now requires a "api key" when searching for games:
api/search/<search_key>. This key gets refreshed every now and then and can be scraped out of one of their scripts. I have implemented the basic functionality of fetching the key before every request based on how it was done in ScrappyCocco/HowLongToBeat-PythonAPI#25.I also noticed that Dark Souls only has 3 platforms. The test required 4. -> I have gone and changed the test.