Style and code quality #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pihart
force-pushed
the
style_pre-import-pdfs
branch
2 times, most recently
from
b7725cd to
364e341
Compare
Draft
…iles` `images` was `any[]` Resolves cjquines#181
…s` handler only respects one file Resolves cjquines#182
pihart
force-pushed
the
style_pre-import-pdfs
branch
from
364e341 to
79c7d2b
Compare
cjquines
reviewed
Jun 13, 2021
| captureRef={(ref) => { | ||
| qboard.globalState.fileInputRef = ref; | ||
| }} | ||
| multiple |
There was a problem hiding this comment.
Yeah, this is done in 0d814b5 to at least make the input consistent with the processing.
#182 (comment) introduces a different solution, but that can still be done afterwards
cjquines
approved these changes
Jun 13, 2021
pihart
commented
Jun 13, 2021
| * | ||
| * @warn | ||
| * Gives you the history commands you must apply, but you must do it yourself. | ||
| * This function does not actually modify history. |
There was a problem hiding this comment.
This warning is no longer correct; fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For merge before #125
Resolves #179
Resolves #181
Resolves #182