Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn Help action into Bindings #144

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Turn Help action into Bindings #144

wants to merge 2 commits into from

Conversation

pihart
Copy link
Collaborator

@pihart pihart commented May 25, 2021

Resolves #143

pihart added 2 commits June 2, 2021 20:12
@pihart
Action.Help is now Action.Bindings
5584319 
**WARNING:** CANNOT change the value from `help` to `keyboard` or `bindings` because existing localStore keymaps will be broken. See cjquines#114 for a solution to this inflexibility
@pihart
New Bindings action should have keyboard icon
818101c
@pihart pihart changed the title Make help icon info Turn help action into bindings Jun 3, 2021
@pihart
Copy link
Collaborator Author

pihart commented Jun 3, 2021

CANNOT change label from help to bindings without an ad-hoc hack or #114 being done first. See 5584319 for more details

@pihart pihart mentioned this pull request Jun 3, 2021
Open
@pihart pihart changed the title Turn help action into bindings Turn Help action into Bindings Jun 9, 2021
@cjquines cjquines marked this pull request as draft June 10, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change help to bindings
1 participant
@pihart