Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change help to bindings #143

Open
pihart opened this issue May 25, 2021 · 5 comments · May be fixed by #144
Open

Change help to bindings #143

pihart opened this issue May 25, 2021 · 5 comments · May be fixed by #144
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pihart
Copy link
Collaborator

pihart commented May 25, 2021

It looks more appealing to me, but more importantly it conveys intent well
image

@cjquines cjquines added the enhancement New feature or request label May 25, 2021
pihart added a commit to pihart/qboard that referenced this issue May 25, 2021
@pihart pihart linked a pull request May 25, 2021 that will close this issue
@cjquines
Copy link
Owner

but still keep it named help? hm. i feel like if youre making it info we should rename it to info

@pihart
Copy link
Collaborator Author

pihart commented May 27, 2021

Good point. On a personal level, I'm good either way; the issue is mainly because it's certainly not a "question."

(If you prefer "info" I'll do that in the PR. I'm also okay with changing it altogether, possibly to "settings" or the like)

@cjquines
Copy link
Owner

"info" does make more sense, i think, compared to "help". but im still not sure what the best solution is. honestly its more like a splash screen or a welcome modal or something idk

@pihart
Copy link
Collaborator Author

pihart commented May 27, 2021

Maybe the rocket or play icons with the name "Start"?

My reservation about rocket is that it's just slightly too prominent in the toolbar:
image

Play has the same issue, but it also

  • looks like it's meant to be a shape tool
  • doesn't make me think a "help" modal will pop up, let alone one with a keyboard and a bindings selector
    image

On that note, maybe icon: "keyboard"; name: "Bindings"/"Hotkeys" is a better fir? Since while it is a splash screen, people will only use it to set hotkeys.
image

And, again, I thinks settings works just as well, if not better

pihart added a commit to pihart/qboard that referenced this issue May 29, 2021
@cjquines
Copy link
Owner

cjquines commented Jun 2, 2021

"bindings" with a keyboard icon makes most sense, i think, in light of #158 wanting a different settings modal?

@pihart pihart changed the title Change help icon to info Change help to bindings Jun 3, 2021
@cjquines cjquines added this to the next milestone Jun 10, 2021
@pihart pihart self-assigned this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants