Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextSearchHighlight):Detach HighlightComponent and TextCearch components #15

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

mon1cakk
Copy link
Contributor

@mon1cakk mon1cakk commented Sep 9, 2024

image

Removed HighlightComponent and TextCearch components for easy use in multiple locations

The HighlightComponent is no longer needed on the Home page due to changes in the
text search functionality. The component has been removed to prevent redundancy and
maintain a clean and efficient codebase.

refactor(TextSearch): use styled-components for highlighting

Refactor the TextSearch component to utilize styled-components for better styling
management. This change allows for more maintainable and scalable CSS practices,
enhancing the component's visual customization capabilities.
Copy link

changeset-bot bot commented Sep 9, 2024

⚠️ No Changeset found

Latest commit: 4f8d232

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mon1cakk mon1cakk closed this Sep 11, 2024
@mon1cakk mon1cakk changed the title Feature/common components feat(TextSearchHighlight):Detach HighlightComponent and TextCearch components Sep 11, 2024
@mon1cakk mon1cakk reopened this Sep 11, 2024
@cjinhuo cjinhuo merged commit 380ae26 into cjinhuo:master Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants