TECH-156 - Update the Civic frontend canister #14
Conversation
CI for local setup
.github/workflows/ci-local.yaml
Outdated
| dfx canister create --all | ||
| - name: Set env variables | ||
| run: | | ||
| export VITE_LOCAL_CIVIC_FRONTEND_CANISTER_ID=$(dfx canister id civic_canister_frontend) |
There was a problem hiding this comment.
If useful when running locally too I would extract this into a script
There was a problem hiding this comment.
but should we leave it in the yaml ?
There was a problem hiding this comment.
the script would be called from the ci yaml then like this
- name: Set env variables
run: |
. ./set-env-vars.sh
.github/workflows/ci-local.yaml
Outdated
| run: | | ||
| chmod +x ic-test-state-machine | ||
| cargo test --test integration_tests | ||
| - run: echo "🐧 This job's status is ${{ job.status }}." |
There was a problem hiding this comment.
the test or the output ?
There was a problem hiding this comment.
the output - the step will fail if the tests fail , or pass if they pass. The echo step will not be called if the tests fail.
There was a problem hiding this comment.
oops the echo is supposed to be a separate step actually. to print the status of the job.
.github/workflows/ci-main.yaml
Outdated
| @@ -0,0 +1,64 @@ | |||
| # name: CI Build and Test (Mainnet setup) | |||
There was a problem hiding this comment.
Is this whole file commented out?
There was a problem hiding this comment.
bc i thought we are writing a script for the mainnet deployment once off. and later we can add the CI for updating that canister on main. i will delete this file then.
| @@ -118,11 +119,11 @@ impl Storable for IssuerConfig { | |||
|
|
|||
| impl Default for IssuerConfig { | |||
| fn default() -> Self { | |||
| let derivation_origin = format!("http://{}.localhost:4943", ic_cdk::id().to_text()); | |||
| let derivation_origin = format!("http://{}.icp0.io", ic_cdk::id().to_text()); | |||
There was a problem hiding this comment.
Should this be parameterised?
There was a problem hiding this comment.
Like passed from the workflow ? But this is the default implementation for the issuer, resolving to mainnet config
There was a problem hiding this comment.
it is using http (not https) is that correct?
What happens if we want to run everything locally, (issuer, RP, Internet Identity). Do we need to change this? In general I wouldn't expect URLs to be stored in canister code hard-coded. Is it good practice?
There was a problem hiding this comment.
actually i fixed this in another branch im working on on the smart contract. its https.
default will only be called if we deploy the canister with no init arguments (in the current deploy script we are always passing arguments). but it has to implement this trait Default
There was a problem hiding this comment.
once this is merged into develop i can apply my smart contract commits on top. so i would leave the http here
| const civicFrontendCanisterUrl = `http://${civicFrontendCanisterId}.${host}`; | ||
|
|
||
| // This is for demo purposes but should be replaced with a more secure method | ||
| const dummyCivicSampleKey = new Uint8Array([ |
There was a problem hiding this comment.
This is for issuing credentials? Can we make it an env var if so?
* TECH-156 - Update the Civic frontend canister * TECH-156 - Get Civic issuing Credential canister to work * alternative origin file with placeholder * configure civic deploy script (including alternative origins) * fix derivationOrigin in civic frontend login * fixes for derivationOrigin * fix the alternative_frontend url in the civic-deploy script * TECH-156 - Add initial commit for the relying canister frontend application * ci for local setup * fix yaml * use npm instead of yarn * test fixes & mainnet ci * TECH-156 - Fix issue with retrieving the credential * snake case for canister names; fix CI * Update README.md * env-vars script & fixes --------- Co-authored-by: Lilly Guo <[email protected]> Co-authored-by: Lilly <[email protected]>
No description provided.