Crash details: Ability to swap addresses #1653
Conversation
| @@ -132,7 +132,7 @@ export default function UserDetails({ | |||
| onClick={() => { | |||
| if ( | |||
| window.confirm( | |||
| "Are you user you want to delete this user?" | |||
| "Are you sure you want to delete this user?" | |||
✅ Deploy Preview for vision-zero-nextjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| disabled={isMutating} | ||
| onClick={async () => { | ||
| if ( | ||
| window.confirm( |
There was a problem hiding this comment.
john and i talked about this and in the future we may create a reuseable confirm/cancel modal to use across the app but for now we are going with window.confirm
|
should we do more auto uppercase on user input here/other places in the app? |
roseeichelmann
requested review from
johnclary,
mateoclarke,
frankhereford,
chiaberry,
tillyw and
mddilley
There was a problem hiding this comment.
It does feel weird that if you are editing and then click the swap addresses button, the input stays open with the previous value. i was trying to come up with a scenario where someone would accidentally duplicate the primary address instead of swapping, but that feels far fetched and the values are in the change log, so nothing would really be lost.
Visually i want the lines to line up better, but its like this in prod now anyway, so mvp mvp 🚢
|
I just saw the comment about auto all caps -- and if its thats how it coming from CRIS, then I think so yes, we should make it match the rest of the data. But I can be convinced otherwise! |
Associated issues
Closes cityofaustin/atd-data-tech#19961
Testing
URL to test:
Local or netlify
Steps to test:
Ship list
mainbranch