Object locking update #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bucket In our object locking guide, we reference the "put-object-retention" commmand instead of the "put-object-lock-configuration" which is used to set the default object lock configuration for newly uploaded objects - without having the user to set it on a per-object level.
We previously referred the use of "put-legal-hold" aws cli command which is wrong. The correct command to use is "put-object-legal-hold" since you can only apply a legal hold to a single object at a time. Also included an alternative way to set the legal hold for multiple objects using the aws cli.
|
@revij This looks good to me now, but I would appreciate an extra pair of eyes from @colder-is-better which is why I have requested a review from him as well. |
| --default compliance 30d \ | ||
| <region>/<bucket> | ||
| ``` | ||
| > `--default` sets the default object lock settings for new objects and |
There was a problem hiding this comment.
Just an insignificant micro-nit:
Suggested change
| > `--default` sets the default object lock settings for new objects and | |
| > The `--default` parameter sets the default object lock settings for new objects and |
Our object locking guide includes the steps neccesary to set the default object lock mode for a bucket but does not include the commands that one can use to set/update the retention mode/period of a single object in a "lock enabled" bucket. Co-authored-by: Florian Haas <[email protected]>
fghaas
force-pushed
the
object-locking-update
branch
from
33dafed to
6685902
Compare
Various syntax fixes for all the references of the mc cli command, including a short notice explaining how to remove the legal hold from an object.
radosgw behaviour sets a legal-hold to the latest version of an object if a version-id is not defined. Updated the aws command example to include --version-id and added a short notice.
fghaas
force-pushed
the
object-locking-update
branch
from
6685902 to
301367c
Compare
colder-is-better
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up from the accidentally closed PR #289.