Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update HowTo in light of worker subnet changes #278

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix: Update HowTo in light of worker subnet changes #278

merged 1 commit into from
Mar 8, 2024

Conversation

colder-is-better
Copy link
Contributor

While creating a new Gardener Shoot cluster, we now have more flexibility regarding the worker nodes subnet. Thus, we update the HowTo prose and add new screenshots.

@colder-is-better colder-is-better changed the title Update HowTo in light of worker subnet changes fix: Update HowTo in light of worker subnet changes Mar 6, 2024
@colder-is-better colder-is-better requested a review from fghaas March 6, 2024 17:45
fghaas
fghaas reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@fghaas fghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, modulo a few minor issues (see comments inline).

docs/howto/kubernetes/gardener/create-shoot-cluster.md Outdated Show resolved Hide resolved
docs/howto/kubernetes/gardener/create-shoot-cluster.md Outdated Show resolved Hide resolved
docs/howto/kubernetes/gardener/create-shoot-cluster.md Outdated Show resolved Hide resolved
docs/howto/kubernetes/gardener/create-shoot-cluster.md Outdated Show resolved Hide resolved
@colder-is-better
fix: Update HowTo in light of worker subnet changes
94237fe 
While creating a new Gardener Shoot cluster, we now have more
flexibility regarding the worker nodes subnet. Thus, we update
the HowTo prose and add new screenshots.
fghaas
fghaas approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@fghaas fghaas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now. The GitHub Actions workflow is due to LinkChecker complaining that an upstream documentation source is currently unavailable, so that's not a "real" merge block.

@fghaas fghaas merged commit 94237fe into citynetwork:main Mar 8, 2024
3 checks passed
@fghaas
Copy link
Contributor

fghaas commented Mar 8, 2024

Merged. Thank you!

@colder-is-better colder-is-better deleted the gardener-custom-net branch December 19, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fghaas fghaas fghaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colder-is-better @fghaas