Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add How-To on managing application credentials #274

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

colder-is-better
Copy link
Contributor

We explain what OpenStack application credentials are, and then we show how to manage them by providing specific examples. While at it, we add a new page regarding Keystone.

Copy link
Contributor

@fghaas fghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start; I have a few suggestions.

docs/howto/openstack/keystone/app-creds.md Show resolved Hide resolved
docs/howto/openstack/keystone/app-creds.md Outdated Show resolved Hide resolved
docs/howto/openstack/keystone/app-creds.md Outdated Show resolved Hide resolved
docs/howto/openstack/keystone/app-creds.md Outdated Show resolved Hide resolved
docs/howto/openstack/keystone/app-creds.md Outdated Show resolved Hide resolved
docs/howto/openstack/keystone/app-creds.md Outdated Show resolved Hide resolved
docs/howto/openstack/keystone/app-creds.md Outdated Show resolved Hide resolved
docs/howto/openstack/keystone/app-creds.md Outdated Show resolved Hide resolved
docs/howto/openstack/keystone/app-creds.md Show resolved Hide resolved
docs/howto/openstack/keystone/app-creds.md Outdated Show resolved Hide resolved
@fghaas
Copy link
Contributor

fghaas commented Jan 23, 2024

One more thing: please add another heading, "Troubleshooting", explaining the source of the Application credentials cannot request a scope error and its remedy.

@colder-is-better
Copy link
Contributor Author

Very nice! I have taken into account all of your suggestions and modified/augmented the prose accordingly. I have also added a new troubleshooting section.

@colder-is-better colder-is-better force-pushed the ostack_app_creds branch 2 times, most recently from 0534492 to 5410113 Compare January 24, 2024 05:00
Copy link
Contributor

@fghaas fghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now. One more tiny addition, and then I think this is good to merge.

docs/howto/openstack/keystone/app-creds.md Show resolved Hide resolved
We explain what OpenStack application credentials are, and then
we show how to manage them by providing specific examples. While
at it, we add a new page regarding Keystone.
Copy link
Contributor

@fghaas fghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@fghaas fghaas merged commit 9d22142 into citynetwork:main Jan 24, 2024
3 checks passed
@colder-is-better colder-is-better deleted the ostack_app_creds branch December 19, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants