build: Use mkdocs-material 9.5.3, drop git-authors theme override #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fghaas
changed the title
fghaas
commented
Dec 13, 2023
tox.ini
Outdated
| @@ -11,7 +11,7 @@ deps = | |||
| mkdocs-git-revision-date-localized-plugin | |||
| mkdocs-glightbox | |||
| mkdocs-macros-plugin | |||
| mkdocs-material~=9.4.0 | |||
| git+https://github.com/squidfunk/mkdocs-material@master | |||
There was a problem hiding this comment.
@colder-is-better: Just a heads-up that this exists. I will update this line to mkdocs-material>=9.5.3 once that version is released, and then I will mark this PR ready for review.
mkdocs-material 9.5.3 gives us the ability to again render authors' names without them turning into "mailto:" links. Thus, require that as the minimum version. Since it is now mkdocs-material that natively renders author information, we no longer need the theme override for main.html. References: https://squidfunk.github.io/mkdocs-material/setup/adding-a-git-repository/#document-authors squidfunk/mkdocs-material#6494
colder-is-better
approved these changes
Dec 28, 2023
fghaas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What will probably become mkdocs-material 9.5.3 gives us the ability to again render authors' names without them turning into "mailto:" links. Thus, require that as the minimum version. Since it is now mkdocs-material that natively renders author information, we no longer need the theme override for main.html.
References:
https://squidfunk.github.io/mkdocs-material/setup/adding-a-git-repository/#document-authors
squidfunk/mkdocs-material#6494