Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Drop the comment workflow #219

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

fghaas
Copy link
Contributor

@fghaas fghaas commented Aug 16, 2023

The workflow introduced in #218, intended to facilitate pull requests by adding a comment in case the PR produced any build errors, failed on its first test. A build failure on #217 did cause the action to fire, but it immediately failed with the following message:

Run quipper/[email protected] 
No open pull requests found with packettoobig-patch-1 branch

Since a pull request from that branch obviously did exist, it follows that the action isn't working as intended, so drop it and rely on per-user build notifications, set via https://github.com/settings/notifications, instead.

The workflow introduced in
citynetwork#218, intended to facilitate
pull requests by adding a comment in case the PR produced any build
errors, failed on its first test. A build failure on
citynetwork#217 did cause the action to
fire, but it immediately failed with the following message:

Run quipper/[email protected]
No open pull requests found with packettoobig-patch-1 branch

Since a pull request from that branch obviously did exist, it follows
that the action isn't working as intended, so drop it and rely on
per-user build notifications, set via
https://github.com/settings/notifications, instead.
@fghaas
Copy link
Contributor Author

fghaas commented Aug 16, 2023

@colder-is-better Apologies for the noise. 'Twas worth a shot. :)

@fghaas fghaas merged commit e6a3ca1 into citynetwork:main Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants