Improve readme #398
Improve readme #398
Conversation
Chrome was not understanding the direct link (did not spawn my irc client)
Help avoid a frustrating surprise
|
|
||
| ```bash | ||
| ./configure | ||
| make |
There was a problem hiding this comment.
Do we need to set the PostgreSQL path here? -- don't know, just asking
There was a problem hiding this comment.
path was not necessary since brew install postgres creates pg_config in path. However I had to run:
brew link openssl --force to create links to openssl headers.
Shouldn't they point at 5.0? This |
| 3. Build and test | ||
|
|
||
| ```bash | ||
| ./configure |
There was a problem hiding this comment.
Need to first run:cd citus before running the rest of the steps.
|
|
||
| ```bash | ||
| # on mac | ||
| brew install postgresql |
There was a problem hiding this comment.
This installs postgresql-9.4.4, not postgres-9.5. It's OK as-is, but might be useful to see if we can brew install postgres 9.5
There was a problem hiding this comment.
Oops @sumedhpathak , regression tests fail on 9.4.5 (i.e., < 9.4.6). see #360 for the details.
There was a problem hiding this comment.
Ok, I see the same errors @onderkalaci mentioned. So @begriffs we should figure out how to get postgres-9.5 via brew as opposed to postgres-9.4.4.
There was a problem hiding this comment.
Uhhhhh? I'm not sure about any of this.
@sumedhpathak — when is the last time you ran brew update? Homebrew doesn't have multiple versions of packages, just the latest. And PostgreSQL is on 9.5.1.
@begriffs — What is postgresql-9.4? Homebrew just has a postgresql package.
There was a problem hiding this comment.
Updating brew instructions to include an update and installation of the postgresql package.
| ```bash | ||
| ./configure | ||
| make | ||
| make install |
There was a problem hiding this comment.
Two notes here:
make installneeds to be run assudomake checkgives me an error both here, and with my manual install. I've never run make check and I don't know what its supposed to do. Should we direct them tosrc/test/regressand run the regression tests there? Alternately let's remove this from here, and put a link after this to our documentation for further setup.
There was a problem hiding this comment.
Actually, sudo is only required for Linux…
|
|
||
| ___ | ||
|
|
||
| Copyright 2012-2016 Citus Data |
There was a problem hiding this comment.
Is this copyright information for the README or for the entire codebase?
If the former, just put Copyright 2016.
There was a problem hiding this comment.
The entire codebase; so I should leave it as-is?
|
Merging this by @ozgune's request. |
This PR addresses some things left out of the initial readme.
irc://link so I changed it to a web client for freenode2012-2016, are they correct?/cc @ozgune