tweak(gamestate/server): sanitize network synchronized scene #3174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
The original GTA network code includes sanitization for local player peds, but it still allows malicious actors to permanently desync a player’s ped on all remote clients. Additionally, other remotely owned entities lack any sanitization, making them vulnerable to similar abuse.
How is this PR achieving the goal
Sanitize
method for all game events, streamlining future sanitization implementations.SET_ENTITY_REMOTE_SYNCED_SCENES_ALLOWED
.GET_ENTITY_REMOTE_SYNCED_SCENES_ALLOWED
.Note: Once this change reaches general availability, client-side sanitization can be removed entirely.
This PR applies to the following area(s)
FiveM, Server
Successfully tested on
Game builds: 3407
Platforms: Windows
Checklist
Fixes issues
/