Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(server): shortened players.json privacy announcement link #3165

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

tabarra
Copy link
Contributor

@tabarra tabarra commented Feb 17, 2025

Goal of this PR

The server players.json IDs privacy announcement link was big, now link is smol.

How is this PR achieving the goal

Used the cfx.re link shortener: https://aka.cfx.re/players-json-privacy

This PR applies to the following area(s)

FXServer, exclusively.

Successfully tested on

Didn't test it at all (except the link itself).

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

None, nobody even complained, but I needed to test the shortener and this particular link has been on my head recently.

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Feb 17, 2025
@Yorick20022
Copy link

Tested locally, looks good to me

image

@FabianTerhorst FabianTerhorst added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Feb 19, 2025
@prikolium-cfx prikolium-cfx merged commit d4ec2ac into citizenfx:master Feb 19, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants