Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(extra-natives-rdr3): add GET_CURRENT_SCREEN_RESOLUTION for RedM #3159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(extra-natives-rdr3): add GET_CURRENT_SCREEN_RESOLUTION for RedM #3159

wants to merge 1 commit into from

Conversation

outsider31000
Copy link
Contributor

@outsider31000 outsider31000 commented Feb 16, 2025 •
edited
Loading

Goal of this PR

Adds a new native to get the screen resolution, since RDR3natives is hardcoded, In RedM there is not a way to get the current screen resolution

big thanks to @Ktos93 for helping out.

How is this PR achieving the goal

by adding this native users can use it to get the correct and current screen resolution

This PR applies to the following area(s)

RedM

Successfully tested on

I'd like to also mention that I've tested switching between resolutions and it gives me the right result.

Game builds: ..
tested on 1491 and 1436
1355 the build it self is broken so I couldn't test on that one.

Platforms: Windows, Linux
windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@github-actions github-actions bot added the RedM Issues/PRs related to RedM label Feb 16, 2025
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Feb 16, 2025
@outsider31000 outsider31000 force-pushed the screen-resolution branch 3 times, most recently from f2fd3d2 to f3ca611 Compare February 16, 2025 08:49
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Feb 16, 2025
@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Feb 16, 2025
@outsider31000 outsider31000 force-pushed the screen-resolution branch 3 times, most recently from 6ee524a to a614925 Compare February 17, 2025 18:52
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action labels Feb 17, 2025
@prikolium-cfx prikolium-cfx self-requested a review February 21, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvarianKnight AvarianKnight AvarianKnight left review comments

@prikolium-cfx prikolium-cfx Awaiting requested review from prikolium-cfx

Assignees
No one assigned
Labels
invalid Requires changes before it's considered valid and can be (re)triaged RedM Issues/PRs related to RedM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@outsider31000 @AvarianKnight