Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit dotnetcore service #82

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Initial commit dotnetcore service #82

merged 6 commits into from
Jan 21, 2025

Conversation

noMoreCLI
Copy link
Contributor

@noMoreCLI noMoreCLI commented Jan 7, 2025

Description

Initial commit of a dotnetcore based service

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@noMoreCLI noMoreCLI requested a review from a team as a code owner January 7, 2025 10:56
Copy link

github-actions bot commented Jan 20, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
nuget/Newtonsoft.Json 13.0.3 🟢 3.3
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 3Found 10/30 approved changesets -- score normalized to 3
Dangerous-Workflow⚠️ -1no workflows found
Token-Permissions⚠️ -1No tokens found
Maintained⚠️ 20 commit(s) and 3 issue activity found in the last 90 days -- score normalized to 2
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy⚠️ 0security policy file not detected
Binary-Artifacts🟢 10no binaries found in the repo
Fuzzing⚠️ 0project is not fuzzed
Vulnerabilities🟢 100 existing vulnerabilities detected
License🟢 10license file detected
Pinned-Dependencies⚠️ -1no dependencies found
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • src/services/dotnetcore/dotnetcore.csproj

@noMoreCLI
Copy link
Contributor Author

@svrnm
Please review this PR.
The code is cleaned up, removed duplicates, local build and test succeeded. And as a bonus - if I did it right - added it to the build script.

@noMoreCLI noMoreCLI added the enhancement New feature or request label Jan 20, 2025
@svrnm svrnm merged commit 5e244f7 into main Jan 21, 2025
13 checks passed
noMoreCLI added a commit that referenced this pull request Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants