-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OPA version from v0.70.0 to v1.0.1 #1526
base: main
Are you sure you want to change the base?
Conversation
e93748c
to
ec8beef
Compare
@@ -258,7 +258,7 @@ function Install-OPAforSCuBA { | |||
) | |||
|
|||
# Constants | |||
$ACCEPTABLEVERSIONS = '0.69.0', [ScubaConfig]::ScubaDefault('DefaultOPAVersion') # End Versions | |||
$ACCEPTABLEVERSIONS = '0.69.0', '0.70.0', [ScubaConfig]::ScubaDefault('DefaultOPAVersion') # End Versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add v1.0.0 as accepted version? Smoke tests pass https://github.com/cisagov/ScubaGear/actions/runs/12958646112
$ACCEPTABLEVERSIONS = '0.69.0', '0.70.0', [ScubaConfig]::ScubaDefault('DefaultOPAVersion') # End Versions | |
$ACCEPTABLEVERSIONS = '0.69.0', '0.70.0', '1.0.0', [ScubaConfig]::ScubaDefault('DefaultOPAVersion') # End Versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OPA v1.0.1 was created to address CVEs in the Go runtime. OPA typically removes the manual download links for the vulnerable version in the website as well. Example in the picture below. Would recommend we keep the versioning consistent to how OPA has the versions displayed on their website, leaving off vulnerable versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran with no errors for G5 interactively/noninteractively.
Ran with no errors for G3 interactively/noninteractively.
Ran with no errors for GCC high interactively/noninteractively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same behavior as v1.0.0 no functional issues with ScubaGear when running with v1.0.1.
Had issues personally with my terminal on one client hanging when trying to do the hash verification. No issues on another client. I chalk that up to isolated client issues.
🗣 Description
💭 Motivation and context
🧪 Testing
✅ Pre-approval checklist
✅ Pre-merge checklist
PR passed smoke test check.
Feature branch has been rebased against changes from parent branch, as needed
Use
Rebase branch
button below or use this reference to rebase from the command line.Resolved all merge conflicts on branch
Notified merge coordinator that PR is ready for merge via comment mention
Demonstrate changes to the team for questions and comments.
(Note: Only required for issues of size
Medium
or larger)✅ Post-merge checklist