Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline comments #532

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

aarz-snl
Copy link
Collaborator

🗣 Description

Closes #531

Removing inline comments from quadlets which cause parsing issues.

💭 Motivation and context

Inline comments cause parsing issues. This causes pods to reset during install as the "timeout" section is not being sec properly. Comments will be removed so install goes without hiccups.

🧪 Testing

Removed comments and tested an install.

✅ Pre-approval checklist

  • Changes are limited to a single goal AND
    the title reflects this in a clear human readable format
  • Issue that this PR solves has been selected in the Development section
  • I have read and agree to LME's CONTRIBUTING.md document.
  • The PR adheres to LME's requirements in RELEASES.md
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.

✅ Pre-merge Checklist

  • All tests pass
  • PR has been tested and the documentation for testing is above
  • Squash and merge all commits into one PR level commit

✅ Post-merge Checklist

  • Delete the branch to keep down number of branches

@aarz-snl aarz-snl merged commit 24ef2fc into develop Dec 13, 2024
2 checks passed
@aarz-snl aarz-snl deleted the awarz-531-remove-inline-comments branch December 13, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants