ci: update goreleaser configs #1007
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amalchuk
reviewed
Jan 19, 2025
fkorotkov
reviewed
Jan 19, 2025
There was a problem hiding this comment.
I think we'll wait for the stable 2.6 version to replace gon.
As for the app_bundle changes, I don't think we need it because of our unique use case and workaround of Apple's constrains.
In our case Tart is actually a CLI and not an App, but in order to have embedded.provisionprofile working we have an *.app like structure of the archive so macOS will respect it. This is why we have this customization in brew section.
amalchuk
approved these changes
Jan 24, 2025
|
This PR also fixes #1003. |
|
fwiw v2.6 is out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see goreleaser/goreleaser#5460
PS: this is not released yet, nightly builds from tonight should have it though.
Also, there's probably files you can delete now, didn't want to mess too much with it because I'm not familiar with the project.
Finally, I have only tested this in
--snapshotmode, so be sure to double check if I didn't break anything :)