Add possibility to create a VM in bridged network mode

[sebastianrakel]

After problems with nftables and libvirtd, i talked with @bastelfreak and we talked about managing the network with systemd-networkd and bridge VMs directly to the systemd-networkd managed bridge.

It was not possible with the current state of this module, so i added an optional setting to create a bridged interface

[trefzer]

Thanks for the request, will review soon (hopefully).
Could you tell me a little more about "problems with nftables and libvirtd" ?

[sebastianrakel]

Thanks for the request, will review soon (hopefully). Could you tell me a little more about "problems with nftables and libvirtd" ?

in our case we need to ensure to first start libvirtd and then nftables only than the firewall rules are present.

if nftables is restarted the firewallrules will be dropped and the vm network is down

it's only happening if libvirtd manages the network

with this PR i can manage the network on my own and the rules are working now

[rayderua]

I have another case for bridged ndework mode.
Example from my home test environment
I have server that already have bridge

auto br0
iface br0 inet static
        bridge_ports enp3s0
        address 172.31.255.200/24
        gateway 172.31.255.1

And i want that start my domins (VMs) will be attachet to exist bridge, and works on host network
But to not manage this interface by libvirt daemon
So we need bridged configuration like this

<interface type='bridge'>
  <mac address='52:54:00:02:d5:9f'/>
  <source bridge='br0'/>
  <model type='virtio'/>
  <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
</interface>

[trefzer]

I think if $iface['bridge_network'] is enough.

[trefzer]

I think if $iface['bridge_network'] is enough.

[trefzer]

@sebastianrakel, @rayderua, @kenyon
I just added pull request #84 to solve this a little bit more generic and add other network types.
Could you have a look at #84 and tell me if this would be a solution ?

Just an additional hint, the bridge configuration is already possible without this merge request, just use one of $devices or $additionaldevices parameter with the following setting:

additionaldevices => { 'interface' => [{
   - 'attrs' => { 'type' => 'bridge' }
     'values' => {
        'model' => {  'attrs' => { 'type' => 'virtio' } },
        'source' => { 'attrs' => { 'bridge' => 'virbr0' }}
     }
}]