Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure if the open file have the good link. #1153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rednaks
Copy link

@rednaks rednaks commented Dec 6, 2020

fixing #1152

@rednaks
Copy link
Author

rednaks commented Dec 7, 2020

it seems that fstat is failing on mac platform any ideas for an alternative api ?

Copy link
Contributor

@k4nar k4nar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Do you think we could use os.path.exists instead?

Also a unit test for this would be awesome 🙏 .

@biozz
Copy link
Contributor

biozz commented Dec 16, 2020

I commented on the original issue with an example of a working setup with logrotate, please check it out. Therefore I think we might not need this change at all.

@rednaks
Copy link
Author

rednaks commented Dec 17, 2020

@k4nar not really because logrotate create a new file the issue is not the existance or not of the file but the link between the open file and the existing file on the disk

@biozz sorry I forgot to reply your comment on the issue, I actually tried it and it doesn't work, it's less frequent but still have the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants