bpf_metadata: extract restoreLocalAddress #1133
Merged
+45
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `extractSocketMetadata` also restores the local address for the use by the `OriginalDestCluster`. To keep the function free of side-effects, the logic that restores the local address gets extracted into a function within the `SocketMetadata` that gets called from the BPF metadata listener after extracting the BPF metadata from the socket. Signed-off-by: Marco Hofstetter <[email protected]>
According to the Envoy sourcecode, restoration of the local address should only be performed if it changes from the current local address. ``` ... This should only be called when restoring the original destination address of a connection redirected by iptables REDIRECT. The caller is responsible for making sure the new address is actually different. ``` Therefore, this commit introduces a check before restoring the local address. Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
force-pushed
the
pr/mhofstetter/bpfmetadata-extract-restorelocaladdress
branch
from
72f07fc to
0e8a156
Compare
jrajahalme
approved these changes
Jan 22, 2025
jrajahalme
approved these changes
Jan 22, 2025
mhofstetter
deleted the
pr/mhofstetter/bpfmetadata-extract-restorelocaladdress
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
extractSocketMetadataalso restores the local address for the use by theOriginalDestCluster.To keep the function free of side-effects, the logic that restores the local address gets extracted into a function within the
SocketMetadatathat gets called from the BPF metadata listener after extracting the BPF metadata from the socket.