Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf_metadata: add unit-test for proxylib l7 proto #1131

Conversation

mhofstetter
Copy link
Member

This commit adds an unit test that verifies that the proxylib l7 protocol has been correctly set to the request application protocols of the network socket.

@mhofstetter mhofstetter requested a review from a team as a code owner January 20, 2025 14:20
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit

tests/metadata_config_test.cc Show resolved Hide resolved
This commit adds an unit test that verifies that the proxylib
l7 protocol has been correctly set to the request application
protocols of the network socket.

Signed-off-by: Marco Hofstetter <[email protected]>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/bpfmetadata-proxylib-unittest branch from 9b212f2 to 1b90bbc Compare January 21, 2025 07:02
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

@jrajahalme jrajahalme added this pull request to the merge queue Jan 21, 2025
Merged via the queue into cilium:main with commit 585ba14 Jan 21, 2025
5 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/bpfmetadata-proxylib-unittest branch January 21, 2025 09:07
@jrajahalme jrajahalme mentioned this pull request Jan 21, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants