Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config): migrate renovate config #2913

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 21, 2025

The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.

You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.

PLEASE NOTE: JSON5 config file migrated! All comments & trailing commas were removed.

🔕 Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.

❓ Got questions? Does something look wrong to you? Please don't hesitate to request help here.


This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added kind/enhancement This would improve or streamline existing functionality. priority/release-blocker This issue will prevent the release of the next version of Cilium. labels Jan 21, 2025
@renovate renovate bot requested a review from a team as a code owner January 21, 2025 12:56
@renovate renovate bot added the renovate/stop-updating Tell Renovate to stop updating PR label Jan 21, 2025
@renovate renovate bot requested a review from bimmlerd January 21, 2025 12:56
@renovate renovate bot mentioned this pull request Jan 21, 2025
3 tasks
@maintainer-s-little-helper
Copy link

Commit e1b9451 does not match "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@bimmlerd
Copy link
Member

I think the change as is isn't great - it drops all comments etc.

But I'll have a look through the changes which aren't purely formatting and try to apply those instead. It seems to me that this renovate config is more complex than it needs to be in the first place, since the only dependency I'd expect this repo to have these days is cilium/cilium.

bimmlerd added a commit that referenced this pull request Jan 22, 2025
These are the actual changes to the schema, as gleaned from the messy
diff of #2913.

Signed-off-by: David Bimmler <[email protected]>
@bimmlerd
Copy link
Member

superseeded by #2915

@bimmlerd bimmlerd closed this Jan 22, 2025
@renovate renovate bot deleted the renovate/migrate-config branch January 22, 2025 12:21
bimmlerd added a commit that referenced this pull request Jan 22, 2025
These are the actual changes to the schema, as gleaned from the messy
diff of #2913.

Signed-off-by: David Bimmler <[email protected]>
tklauser pushed a commit that referenced this pull request Jan 22, 2025
These are the actual changes to the schema, as gleaned from the messy
diff of #2913.

Signed-off-by: David Bimmler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-merge/needs-sign-off kind/enhancement This would improve or streamline existing functionality. priority/release-blocker This issue will prevent the release of the next version of Cilium. renovate/stop-updating Tell Renovate to stop updating PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant