Do not allow slug to be set for unnamed policies #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarnes52
force-pushed
the
bgb/slugnotallowedifunnamed
branch
2 times, most recently
from
00665da to
2d65c74
Compare
bbarnes52
changed the title
bbarnes52
force-pushed
the
bgb/slugnotallowedifunnamed
branch
from
2d65c74 to
3712cc9
Compare
prashantv
approved these changes
Oct 29, 2024
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| Added: | |||
| * Allow `chronosphere_notification_policy` resources without a `team_id`. | |||
| * Reject unnamed `chronosphere_notification_policy` resources that set a `slug` | |||
There was a problem hiding this comment.
was this already the case prior to the above change? if so, i think we can drop this, and add a skip-changelog label to the PR to skip the changelog check
| @@ -320,6 +329,10 @@ func expandNotificationPolicyRaw( | |||
|
|
|||
| // expandNotificationPolicy converts a notification policy resource to the corresponding API model type. | |||
| func expandNotificationPolicy(p *intschema.NotificationPolicy) (*NotificationPolicyData, error) { | |||
| isInline := p.Name == "" | |||
| if p.Slug != "" && isInline { | |||
| return nil, fmt.Errorf("cannot set slug for unnamed policy, can only set slug for policy with name set") | |||
There was a problem hiding this comment.
nit: not sure why this error message is inconsistent with the one above, should we use the same message in both places?
bbarnes52
force-pushed
the
bgb/slugnotallowedifunnamed
branch
from
3712cc9 to
4ecb2a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slug should not be allowed for inline policies. This invariant was inadvertently relaxed in #83 though never released.
Scenario test build 25 completed successfully.