add CI job to enforce CHANGELOG.md updates #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aschepis
force-pushed
the
aschepis/ci-changelog-check
branch
from
6746cbe to
225ab19
Compare
prashantv
approved these changes
Apr 3, 2024
| @@ -4,9 +4,18 @@ name: Go | |||
| on: | |||
| push: | |||
| branches: main | |||
| pull_request: # don't include branches so that all PRs run. | |||
| pull_request: | |||
| types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] | |||
There was a problem hiding this comment.
Is this an intentional change, if so, can you add some context for why we need to change this?
There was a problem hiding this comment.
sure. the reason is that labeled and unlabeled are not included in the default list of types to run CI on and so if you add the skip-changelog or ignore-release label it won't re-run CI. i'll add a comment in code
aschepis
force-pushed
the
aschepis/ci-changelog-check
branch
from
225ab19 to
539837a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the dangoslen/changelog-enforcer marketplace action to ensure that the CHANGELOG.md
is being updated with each PR merged into the repo. This can be bypassed for
changes that are not customer impacting by applying the
skip-changelogorignore-releaselabels to the PR.