Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-8151]: adds command, cmd overrides and addtional configsUrl param #171

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

WesleyCharlesBlake
Copy link
Member

@WesleyCharlesBlake WesleyCharlesBlake commented Sep 20, 2024

Q                       A
Service (ghost)
Fixed Issues? Fixes sc-8151
Patch: Bug Fix? yes - tor socks
Major: Breaking Change? no
Minor: New Feature? no- optional overrides for different use cases
Tests Added + Pass? Yes
Documentation PR [skip-ci]
Any Dependency Changes?
License AGPL

description of pull request:

  • fixes socks port on tor
  • adds command override
  • adds arguments override
  • adds configUrl

@WesleyCharlesBlake WesleyCharlesBlake changed the title adds command, cmd overrides and addtional configsUrl param [sc-8151]: adds command, cmd overrides and addtional configsUrl param Sep 20, 2024
@WesleyCharlesBlake
Copy link
Member Author

Fixes sc-8151

@WesleyCharlesBlake
Copy link
Member Author

Copy link
Member Author

@WesleyCharlesBlake WesleyCharlesBlake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Values.ghost.commandOverride, .Values.ghost.argsOverride, and .Values.ghost.configsUrl all provide additional configuration for runtime, and can be used individually, or within any combination of the 3. default is optional forcing the default args, and container entrypoint to be used (preferred)

@teghnet teghnet changed the base branch from main to sc-8151-enable-command-and-args-override-in-validator September 23, 2024 11:49
@WesleyCharlesBlake WesleyCharlesBlake changed the base branch from sc-8151-enable-command-and-args-override-in-validator to main September 23, 2024 15:27
charts/validator/templates/deployment.yaml Show resolved Hide resolved
charts/validator/templates/deployment.yaml Show resolved Hide resolved
charts/validator/templates/deployment.yaml Outdated Show resolved Hide resolved
charts/validator/templates/deployment.yaml Show resolved Hide resolved
charts/validator/values.yaml Show resolved Hide resolved
charts/validator/values.yaml Show resolved Hide resolved
charts/validator/values.yaml Outdated Show resolved Hide resolved
@teghnet teghnet force-pushed the validator_overrides branch from 0e47816 to 15f79c0 Compare October 2, 2024 15:18
@WesleyCharlesBlake WesleyCharlesBlake merged commit 930d983 into main Oct 2, 2024
2 checks passed
@WesleyCharlesBlake WesleyCharlesBlake deleted the validator_overrides branch October 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants