New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix implicitly nullable parameter in AbstractBinaryInput::getRawBinary() #674

Merged

GrahamCampbell merged 1 commit into chrome-php:1.12 from HenryVolkmer:bugfix/implicitly-nullable-param

Jan 3, 2025

Contributor

HenryVolkmer commented Jan 3, 2025

possibly overlooked in PR #660


          - bugfix implicitly nullable parameter in AbstractBinaryInput::getRaw…

eb0ac18

…Binary()

enricodias approved these changes

View reviewed changes

GrahamCampbell merged commit 8a6052c into chrome-php:1.12

21 checks passed

Contributor

divinity76 commented Feb 6, 2025 •

edited

Loading

I kinda need this in a release. Any chance we could do a 1.12.1 release? ping @enricodias @GrahamCampbell

Fatal error: Uncaught ErrorException: HeadlessChromium\PageUtils\AbstractBinaryInput::getRawBinary(): Implicitly marking parameter $timeout as nullable is deprecated, the explicit nullable type must be used instead in /var/www/vendor/chrome-php/chrome/src/PageUtils/AbstractBinaryInput.php on line 66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet