single escape for writing SQL execution #707
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self._conn.execute
(line 296 of chromadb/db/duckdb.py) will throw a Binder Error ifids
given to Clickhouse._create_where_clause (line 136 of chromadb/db/clickhouse.py) contains single quote. And the solution is to escape single quotes by replacing them to double single quotes (see https://stackoverflow.com/questions/1586560/how-do-i-escape-a-single-quote-in-sql-server). Meanwhile, single quotes will cause the tuple formatted with double quotes, which will cause other problem (see https://stackoverflow.com/questions/75671499/duckdb-binder-error-referenced-column-not-found-in-from-clause), therefore a two-step-replacement is performed.