Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release-plz checking next version #99

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix release-plz checking next version #99

merged 1 commit into from
May 2, 2024

Conversation

chrjabs
Copy link
Owner

@chrjabs chrjabs commented May 2, 2024

Description of the Contribution

If a file is ignored in a repository but still committed in it, that really messes with release-plz. Remove committed Makefiles from glucose repo to fix CI.

resolves #98

PR Checklist

  • I read and agree to CONTRIBUTING.md
  • I have formatted my code with rustfmt / cargo fmt --all
  • Commits are named following conventional commits
  • I have added documentation for new features
  • The test suite still passes on this PR
  • I have added tests for new features / tests that would have caught the bug this PR fixes (please explain if not)

if a file is ignored in a repository but still committed in it, that
really messes with release-plz. remove committed Makefiles from glucose
repo to fix ci
@chrjabs chrjabs merged commit ca2b7e0 into main May 2, 2024
44 checks passed
@chrjabs chrjabs deleted the fix/release-ci branch May 2, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix release-plz workflow
1 participant