Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate transform opts in tests #97

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MaoShizhong
Copy link
Contributor

@MaoShizhong MaoShizhong commented Feb 12, 2025

This PR

  • Uses single source of truth for transform opts in tests since they're all the same.

Depending on what gets approved and merged with #95, #96 or #99, and in what order, I'll amend PRs as needed since the other two still use the original opts object literal.

@christina-de-martinez
Copy link
Owner

Thanks so much for all these PRs @MaoShizhong !! Looks like there's a merge conflict now, like you expected

@MaoShizhong
Copy link
Contributor Author

@christina-de-martinez All cleaned up. I'll sort out #99 after this one's merged since it'll be more straightforward to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants