Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sort quality levels #46

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

eban5
Copy link
Contributor

@eban5 eban5 commented Dec 8, 2020

This PR addresses a feature request for ordering the quality levels in descending order ( #38 ). I found a use for this type of feature, so I figured I would throw together a PR.

  • Adds a sortAscending config parameter (boolean) that defaults to true (how it currently sorts the list)
  • Adds a autoPlacement config parameter (string) that defaults to placing the 'auto' label at the bottom (how it currently places the item)

@eban5
Copy link
Contributor Author

eban5 commented Feb 22, 2021

Just wanted to drop by and see if there was any interest to bring this feature into the plugin?

@elcorders
Copy link

Hi, this would be an amazing addition, literally came here looking for this. @eban5

@andreasgangso
Copy link
Contributor

Hi, I created a PR in your repo to:

  • Make descending and 'top' default, because this is more common (e.g. youtube, vimeo)
  • Use config directly instead of passing them as parameters

eban5#1

@hitriyvalenok
Copy link

+1 for this change.

This is great! Thanks for making the PR and sorry for the long delay in getting back.
@romanberdnikov
Copy link

+1 for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants