Merge branch '5550/xdrill-transactions' into 5551/xdrill-operations

chowbao · Jan 21, 2025 · 3d7876c · 3d7876c
2 parents 3bc82f4 + b6851fc
commit 3d7876c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/ingest/ledger/ledger.go b/ingest/ledger/ledger.go
@@ -93,8 +93,8 @@ func Signature(l xdr.LedgerCloseMeta) (string, bool) {
 	return base64.StdEncoding.EncodeToString(LedgerCloseValueSignature.Signature), true
 }
 
-// TransactionCounts calculates and returns the number of successful and failed transactions
-func TransactionCounts(l xdr.LedgerCloseMeta) (successTxCount, failedTxCount uint32) {
+// TransactionCounts calculates and returns the number of successful and total transactions
+func TransactionCounts(l xdr.LedgerCloseMeta) (successTxCount, totalTxCount uint32) {
 	transactions := l.TransactionEnvelopes()
 	results, err := l.TxProcessing()
 	if err != nil {
@@ -109,12 +109,10 @@ func TransactionCounts(l xdr.LedgerCloseMeta) (successTxCount, failedTxCount uin
 	for i := 0; i < txCount; i++ {
 		if results[i].Result.Successful() {
 			successTxCount++
-		} else {
-			failedTxCount++
 		}
 	}
 
-	return successTxCount, failedTxCount
+	return successTxCount, uint32(txCount)
 }
 
 // OperationCounts calculates and returns the number of successful operations and the total operations within

diff --git a/ingest/ledger/ledger_test.go b/ingest/ledger/ledger_test.go
@@ -48,14 +48,14 @@ func TestLedger(t *testing.T) {
 	assert.Equal(t, "9g==", signature)
 
 	var success uint32
-	var failed uint32
-	success, failed = TransactionCounts(ledger)
+	var total uint32
+	success, total = TransactionCounts(ledger)
 	assert.Equal(t, uint32(1), success)
-	assert.Equal(t, uint32(1), failed)
+	assert.Equal(t, uint32(2), total)
 
-	success, failed = OperationCounts(ledger)
+	success, total = OperationCounts(ledger)
 	assert.Equal(t, uint32(1), success)
-	assert.Equal(t, uint32(13), failed)
+	assert.Equal(t, uint32(13), total)
 }
 
 func ledgerTestInput() (lcm xdr.LedgerCloseMeta) {