Remove curry option and migrate to prototypes

[marcbachmann]

The changes in here remove the curry option and migrate to prototypes as discussed in #12 and #6.
This pull request currently also includes a change done in #9. So we could do two releases (minor & major) or just a major one.

Api changes

• The curry option got removed as mentioned in
• We've migrated the api to prototypes, so the returned router function doesn't exist anymore. Please use router.emit(path) instead

const router = require('nanorouter')({default: '/404'})

// Registers a handler to a specific route
router.on('/path', function (params) {
  return 'something'
})

// Executes a handler, passes `params` as first argument
// Returns the value of the executed handler
const returnValue = router.emit('/path')

// Returns a matched route, falls back to the default route or throws if nothing is found
router.match('/path')

Migration from the old curry option

The curry option was confusing to use and read. Therefore we removed that completely.
Previously it was possible to use the curry option like that:

const router = require('nanorouter')({curry: true})
router.on('/hello/:someparam', function (params) {
  return function () {
    return {hello: params.someparam}
  }
})

const returnvalue = router.emit('/something/world')
// returnvalue === '{"hello": "world"}'

Now that this option doesn't exist anymore, we advise you to migrate to the .match() method as it's much more flexible in case you'll need more advanced parameters.

const router = require('nanorouter')()
router.on('/hello/:someparam', function (params) {
  return {hello: params.someparam}
})

const route = router.match('/something/world')
const returnvalue = route.cb(route.params)
// returnvalue === '{"hello": "world"}'

if you won't have time to migrate your code and want to keep the old behavior, just wrap everything in a self-executing function.

router.on('/hello/:someparam', function (params) {
  return (function () {
    return {hello: params.someparam}
  })()
})

// or wrap the registration of the handler in a function
const router = require('nanorouter')()
function onRoute (path, handler) {
  router.on(path, function (params) {
    var modifiedParameters = {params: params}
    return handler(modifiedParameters)
  })
}

[yoshuawuyts]

Happy new year! This is great! Left some minor comments that will probably allow us to make the bundle slightly smaller. Other than that this is 👌

[yoshuawuyts]

I think we should remove this function, and write these statements inline. This has two benefits:

1. writing duplicate code compresses better. So while having more code in source, it'll probably end up being less code sent over the wire.
2. this no longer works with static transforms such as unassertify and tinyify.

Hope this makes sense!

[marcbachmann]

Yes, definitely. I didn't think about lz/gzip compression. 👍
I'll just use assert then; that's basically already in use every setup and works better for the reason you mentioned.

[yoshuawuyts]

The onRoute variable name doesn't do anything in this code. Could we perhaps remove the variable names from all methods, and only keep the method names?

[marcbachmann]

I've just added it to have a named function.
But usually nobody does this for prototype methods, nor do I usually 😁 .
ES6 improved anonymous functions a lot by defining the name automatically for the new syntaxes and let and const. But as we're still using prototypes, I'm good with removing it.
This module is quite small anyways and the function name of the constructor might be good enough.

[yoshuawuyts]

Really digging the tests! 🎉

[marcbachmann]

@yoshuawuyts Happy new year and thanks for the review.
I just pushed the requested changes.

[yoshuawuyts]

nice! - sorry for the delay in reviewing, this is amazing :D

[yoshuawuyts]

v3.0.0 🎉

[marcbachmann]

No problem. Thanks for your work. 🎉