Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate the non .match() API #12

Open
yoshuawuyts opened this issue Dec 28, 2017 · 2 comments
Open

deprecate the non .match() API #12

yoshuawuyts opened this issue Dec 28, 2017 · 2 comments

Comments

@yoshuawuyts
Copy link
Member

When #9 lands, we should deprecate the other API. We should probably also take that chance to deprecate .curry (related to #10) and rewrite this to prototypes (as per #6).
@yoshuawuyts yoshuawuyts mentioned this issue Dec 28, 2017
Closed
@marcbachmann
Copy link
Contributor

The new .match method only returns a matched route, but doesn't invoke the handler.
So I'd still keep the .emit method.

@yoshuawuyts
Copy link
Member Author

@marcbachmann yeah, alright. Sounds fair!

This was referenced Dec 29, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcbachmann @yoshuawuyts