cache-component <-> nanocomponent [email protected] #38
+642
−865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* begin cache function * clean up for linting * clean up for linting * adds initial implementation based on jekrb's code. Adds tests that checks memoization is working as expected
* feat(cache-element): write impl. * fixup! fix impl
widget update called with arguments, not arg array
* feat(widget): redo * feat(cache): update * feat(docs): update for el rework
2.0.1
|
neato!
…On Thu, Jul 13, 2017 at 6:19 AM Bret Comnes ***@***.***> wrote:
Merge branch for the cache-component and nano component merge
resonance-cascade/cache-component#18
<resonance-cascade/cache-component#18>
------------------------------
You can view, comment on, or merge this pull request online at:
#38
Commit Summary
- .
- fix(docs): faq
- Continued implementation based on @jekrb's code (#4)
- Implement cache (#5)
- fix(travis): bump versions
- 1.0.1
- feat(widget): init (#6)
- 1.1.0
- fix(widget): fix argument passing (#7)
- 1.1.1
- feat(build): add UMD build (#13)
- 1.1.2
- 1.1.3
- chore(package): update envify to version 4.0.0 (#14)
- feat(index): update API (#18)
- 2.0.0
- s/const/var
- 2.0.1
- Initial commit
- initial commit
- add assertions
- Merge tag 'v2.0.1'
- update readme
- improve docs on _update method
- fix tests
- a few tweaks
- update package.json
- 3.0.0-0
- update _update function signature
- 3.0.0-1
- handle DOM removal
- Merge pull request #3 from blahah/patch-1
- 3.0.0-2
- Restore proxied mutated elements (solves #4)
- Merge pull request #5 from hypermodules/proxy-mutants
- 3.0.0-3
- update readme
- putting a bow on it
- cache proxy
- use direct proxy logic
- only capture dom references once
- prepare for 3.0.0 release
- v3.0.0
- remove old publishing stuff
- fix readme typos
- fix another typo
- Merge pull request #6 from hypermodules/typos
- implement dom loading lifecycles
- handle morphing internally
- Merge remote-tracking branch 'origin/master'
- v4.0.0
- fix weird tests that don't really test
- update readme
- fix instance morph clobbering
- fix one last thing
- also id rendered elements
- Merge pull request #9 from hypermodules/instance-clobber
- v4.0.1
- Update README.md
- Update README.md
- run unload methods before clearing internal refs
- v4.0.2
- update lock file
- Experiment to remove on-load
- Use nanomorph again and add ._didUpdate
- Update changelog
- Merge pull request #12 from hypermodules/5.0.0-beta
- v5.0.0-1
- chore(package): update bel to version 5.0.0
- fix(package): update nanomorph to version 5.0.0
- Fix spelling in Error thrown by default '_render' method
- Merge pull request #17 from joshgillies/fix-error-message
- Merge pull request #15 from hypermodules/greenkeeper/bel-5.0.0
- Merge pull request #16 from hypermodules/greenkeeper/nanomorph-5.0.0
- Update changelog about bel. Prep for 5.0.0
- v5.0.0
- Merge branch 'master' into 6
- update nanomorph again
- Reset proxy after dom-removal
- v5.0.1
- spelling in CHANGELOG
- Merge commit '04209bca60676f9e6c1256373cf0ebe0b8e9f052'
- v5.1.0
- Add more lifecycle hooks
- v5.2.0
- Add optional on-load lifecycles
- rename this._element to this.element
- Remove noop
- Add assertions
- More tweaks
- a few edits on the README
- Update README.md
- Update README.md
- Minor var tweak
- More renaming
- Merge remote-tracking branch 'origin/optional-onload' into
optional-onload
- Fix server side tests
- Add examples to README
- Update reademe
- bel free example
- add unload example
- reorder
- remove link
- rework docs
- Merge pull request #19 from hypermodules/rework-docs
- Add other lifecycle module references
- Merge branch 'optional-onload' into nc-master
- Added a few links back to the readme
- darnit dont yarn it
File Changes
- *M* .travis.yml
<https://github.com/choojs/nanocomponent/pull/38/files#diff-0> (15)
- *A* CHANGELOG.md
<https://github.com/choojs/nanocomponent/pull/38/files#diff-1> (35)
- *M* README.md
<https://github.com/choojs/nanocomponent/pull/38/files#diff-2> (384)
- *M* index.js
<https://github.com/choojs/nanocomponent/pull/38/files#diff-3> (156)
- *M* package.json
<https://github.com/choojs/nanocomponent/pull/38/files#diff-4> (62)
- *A* test.js
<https://github.com/choojs/nanocomponent/pull/38/files#diff-5> (33)
Patch Links:
- https://github.com/choojs/nanocomponent/pull/38.patch
- https://github.com/choojs/nanocomponent/pull/38.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWleo4-ToNuZ_23WU7KZI9shD79658dks5sNZrngaJpZM4OWe_V>
.
|
|
I'm going to release a beta to allow for easy consumption and encourage early feedback. |
|
@yoshuawuyts I don't seem to have publish access yet on npm. Can I get that add? Also whats your view on beta branches? Merged to master on beta? Merged to master after a real release? |
|
added to npm
…On Mon, Jul 17, 2017 at 3:59 AM Bret Comnes ***@***.***> wrote:
@yoshuawuyts <https://github.com/yoshuawuyts> I don't seem to have
publish access yet on npm. Can I get that add?
Also whats your view on beta branches? Merged to master on beta? Merged to
master after a real release?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACWleitOoOXU4Uo6iGGRntCSq-fV44iRks5sOsAXgaJpZM4OWe_V>
.
|
|
Also, think we should just merge to master - put out a beta release (e.g.
prerelease) and once we find it stable enough, we publish a full major
…On Mon, Jul 17, 2017 at 3:00 PM yoshua wuyts ***@***.***> wrote:
added to npm
On Mon, Jul 17, 2017 at 3:59 AM Bret Comnes ***@***.***>
wrote:
> @yoshuawuyts <https://github.com/yoshuawuyts> I don't seem to have
> publish access yet on npm. Can I get that add?
>
> Also whats your view on beta branches? Merged to master on beta? Merged
> to master after a real release?
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> <#38 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACWleitOoOXU4Uo6iGGRntCSq-fV44iRks5sOsAXgaJpZM4OWe_V>
> .
>
|
bcomnes
changed the title
bcomnes
changed the title
|
Ok merging to master. Released as 6.0.0-0. Installable with |
|
Actually lets do it tomorrow. If you are reading this on July 18, and you don't see anything wrong, go ahead and smash that merge button. Going to announce in IRC and get preprefeedback this evening. |
|
Actually I'll just do it now. Revert exists for a reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge branch for the cache-component and nano component merge resonance-cascade/cache-component#18
Remaining work broken out into: #39