Fixes Jenkins Pushing and ClientSetup #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic used in the client setup script to search for the latest version of Chocolatey available in the Repository URL had a minor flaw - Using TrimEnd could result in repositories ending in any of the characters in "index" could trim too much. This commit replaces that logic with regex, which hopefully will remove a problem.
Updates to Chocolatey CLI mean that we can not rely on implicit credentials for a source. This change ensures credentials for each potential source are added to the machine, for Jenkins to use.
JPRuskin
force-pushed
the
clientJenkinsFixes
branch
from
290c0d2 to
5ff550c
Compare
steviecoaster
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This change ensures credentials for each potential source are added to the machine, for Jenkins to use. It also tightens up the ClientSetup script, to ensure it's not going to fail when used with repositories named by others.
Motivation and Context
Updates to Chocolatey CLI mean that we can not rely on implicit credentials for a source.
Testing
Operating Systems Testing
Change Types Made
[ ] Feature / Enhancement (non-breaking change).[ ] Breaking change (fix or feature that could cause existing functionality to change).[ ] Documentation changes.Change Checklist
[ ] Requires a change to the documentation.[ ] Documentation has been updated.[ ] Tests to cover my changes, have been added.[ ] PowerShell code changes: PowerShell v3 compatibility checked?Related Issue
Fixes #286
Fixes #285