Remove default.nix and link to external package #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Demeester <[email protected]>
chmouel
approved these changes
Dec 1, 2023
|
Ah still there ? We can remove yes. |
|
@chmouel yeah there is not nix gha anymore in the repository I think. |
|
It should probably also mention nixpkgs too :) |
What do you mean ? Is it packaged in nixpkgs ? |
|
(If yes, I can remove it from my repo and rely only on upstream 🤭🤭🤭) |
|
Oh yeah it is !! 🎉👏🏼 @06kellyjac |
|
@vdemeester would you like to change this to use nixpkgs then? (and thanks @06kellyjac 🙏🏻 ) |
yes I will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Demeester [email protected]