merge vcs run and verilator run to keep change in sync #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avimitin
force-pushed
the
hook-base-run
branch
5 times, most recently
from
4ab4c54 to
14ec913
Compare
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
hook-base-run
branch
4 times, most recently
from
daf109a to
eef94b3
Compare
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
hook-base-run
branch
from
eef94b3 to
468f51e
Compare
Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
hook-base-run
branch
from
f1b541b to
0f7d922
Compare
|
I try with |
Signed-off-by: Avimitin <[email protected]>
|
Bash variable evaluation got some unexpected behavior during refactor process. Should be fixed now. Also new tests added to ensure waveform files exist. |
|
LGTM, I test locally, all vcs/verilator-emu/emu-trace and vcs-emu-cover work flawlessly |
FanShupei
previously approved these changes
Jan 22, 2025
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
hook-base-run
branch
from
8e1834e to
5aa83be
Compare
qinjun-li
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.