image: Implement new methods for RustCrypto provider #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swenson
requested review from
mhatrevi,
ajisaxena,
vsonims,
korran and
JohnTraverAmd
as code owners
swenson
force-pushed
the
print-hashes-rustcrypto-fixes
branch
from
2cbfc02 to
1385adc
Compare
Some new methods were added to the image crypto trait but the rustcrypto provider was not updated, so the build was failing with rustcrypto. Also, the rustcrypto provider was specifying compressed points for ECDSA public keys, even though for OpenSSL we always use uncompressed, which was causing keys not to be parsed correctly in RustCrypto. To ensure that won't happen again, we also add a test that the workspace members that use rustcrypto are now built with both sets of flags. We also add an option to print the vendor and owner PK hashes when building an firmware image bundle. This makes it easier to test the recovery flow.
swenson
force-pushed
the
print-hashes-rustcrypto-fixes
branch
from
1385adc to
3dcd6a3
Compare
jhand2
reviewed
Feb 5, 2025
ArthurHeymans
approved these changes
Feb 6, 2025
mhatrevi
approved these changes
Feb 7, 2025
|
Thanks! |
jhand2
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some new methods were added to the
ImageGeneratorCryptotrait but the RustCrypto implementation was not updated, so the build was failing when using therustcryptofeature flag.Also, the RustCrypto provider was specifying compressed points for ECDSA public keys, even though for OpenSSL we always use uncompressed, which was causing keys not to be parsed correctly with the RustCrypto provider.
To ensure that won't happen again, we also add a test that the workspace members that use the
rustcryptofeature flag are now built with both sets of flags.We also add an option to print the vendor and owner PK hashes when building a firmware image bundle. This makes it easier to test the recovery flow.