Adding hw-1.0 build test and FMC size fix #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nquarton
changed the title
nquarton
force-pushed
the
hw-1.0_fmc_build_fix_and_ci_check
branch
from
db03b08 to
1adf6c7
Compare
|
We should add a compile time assertion to constrain the combined size of FMC and RT to 118kb as per Jordan's comment. |
That is probably a good idea. I'm not quite sure how to go about doing that though. Do you have an idea? |
nquarton
force-pushed
the
hw-1.0_fmc_build_fix_and_ci_check
branch
from
1adf6c7 to
f97396d
Compare
nquarton
force-pushed
the
hw-1.0_fmc_build_fix_and_ci_check
branch
from
f97396d to
64dd25e
Compare
This has been addressed now |
nquarton
requested review from
FerralCoder,
rusty1968,
bluegate010,
mhatrevi,
swenson and
vsonims
as code owners
rusty1968
approved these changes
Feb 5, 2025
clundin25
approved these changes
Feb 5, 2025
jhand2
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding check that runs during build and test for FMC and RT build for hw-1.0
Adjusting FMC logging to fix size issue on hw-1.0
Adding compile-time check to limit runtime (FMC+FW) size to 118kB (128-10kB for the manifest)