Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unused hw-1.0 feature to zero_bin crate to satisfy builder requirements #1915

Merged

Conversation

nquarton
Copy link
Contributor

@nquarton nquarton commented Jan 28, 2025

The image builder passes on the hw-1.0 feature to individuals builds for each component. The zero-bin crate had not defined this feature because it was not needed. This adds the feature to prevent an error that the hw-1.0 feature is not defined.

@nquarton nquarton changed the title Adding unused hw-1.0 feature to zero_bin crate to satisfy builder req… Adding unused hw-1.0 feature to zero_bin crate to satisfy builder requirements Jan 28, 2025
@nquarton nquarton linked an issue Jan 28, 2025 that may be closed by this pull request
@nquarton nquarton marked this pull request as ready for review January 28, 2025 01:11
@nquarton nquarton force-pushed the nightly_release_zero_bin_hw-1.0_fix branch from 2e011e5 to ce5f5f1 Compare January 28, 2025 23:53
@jhand2 jhand2 merged commit 37dc9b1 into chipsalliance:main Jan 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly release CI failing for hw-1.0 not being defined
2 participants