ci: Build ROM release from versioned git ref (revive) #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhand2
reviewed
Jan 24, 2025
| @@ -25,6 +25,9 @@ on: | |||
| rom-version: | |||
| default: "latest" | |||
| type: string | |||
| rom-ref: | |||
There was a problem hiding this comment.
I think ultimately our goal is for the nightly release workflow to be runnable with specified ROM & FW refs. Would it make sense to try to factor out some of the steps in this file so it can be reused in the nightly one as well?
Not sure if that would improve things or just make the CI more confusing.
Signed-off-by: Benjamin Doron <[email protected]>
* trap exit (induced e.g. by set -e) and add cleanup when script calls early exit * update script to comply with SC2086 * change return codes to 0-255 range SC2242 * add verbosity flags for commands modifying the filesystem Signed-off-by: leongross <[email protected]>
leongross
force-pushed
the
leongross/build_versioned_release_rom
branch
from
362878e to
1d48817
Compare
leongross
commented
Jan 31, 2025
|
|
||
| - name: Generate release zip | ||
| run: | | ||
| ./ci-tools/release/build_release.sh "_versioned_build_test_" ${{ inputs.rom-ref }} ${{ inputs.firmware-version }} |
There was a problem hiding this comment.
So when we talk about firmware this means FMC and RT, right? So we don't want to consider different revisions for FMC and RT?
There was a problem hiding this comment.
Ya, I think currently it's fine to build FMC and RT from the same revision.
Signed-off-by: leongross <[email protected]>
nightly-release.yml Signed-off-by: leongross <[email protected]>
Signed-off-by: leongross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revive of PR #1604.