Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Increase ICCM size to 256 KB #1896

Closed
wants to merge 1 commit into from
Closed

[feat] Increase ICCM size to 256 KB #1896

wants to merge 1 commit into from

Conversation

mhatrevi
Copy link
Collaborator

This change updates the ICCM size from 128 KB to 256 KB.

@mhatrevi
[feat] Increase ICCM size to 256 KB
56d8721 
This change updates the ICCM size from 128 KB to 256 KB.
@mhatrevi mhatrevi added the Caliptra v2.0 Items to be considered for v2.0 Release label Jan 16, 2025
MDr164
MDr164 reviewed Jan 20, 2025
View reviewed changes
Copy link

@MDr164 MDr164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issue in doing so but could you maybe add a rationale on why this becomes necessary now to the commit or PR text?

@mhatrevi
Copy link
Collaborator Author

Abandoing this PR as #1901 covers the ICCM size update.

Please see chipsalliance/caliptra-rtl#646 for the justification of the size increase.

@mhatrevi mhatrevi closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MDr164 MDr164 MDr164 left review comments

@korran korran Awaiting requested review from korran korran is a code owner

@fdamato fdamato Awaiting requested review from fdamato fdamato is a code owner

@jlmahowa-amd jlmahowa-amd Awaiting requested review from jlmahowa-amd jlmahowa-amd is a code owner

@jhand2 jhand2 Awaiting requested review from jhand2 jhand2 is a code owner

@swenson swenson Awaiting requested review from swenson swenson is a code owner

@vsonims vsonims Awaiting requested review from vsonims vsonims is a code owner

@ajisaxena ajisaxena Awaiting requested review from ajisaxena ajisaxena is a code owner

@JohnTraverAmd JohnTraverAmd Awaiting requested review from JohnTraverAmd JohnTraverAmd is a code owner

@rusty1968 rusty1968 Awaiting requested review from rusty1968 rusty1968 is a code owner

Assignees
No one assigned
Labels
Caliptra v2.0 Items to be considered for v2.0 Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhatrevi @MDr164