Skip to content

Commit

Permalink
fix(ci): Enclose REL_VER variable in quotes in build workflow to ensu…
Browse files Browse the repository at this point in the history
…re proper handling of version strings

fix: #5
  • Loading branch information
chenx-dust committed Jan 23, 2025
1 parent 7b7129c commit 605090b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
cmake -DNIGHTLY_BUILD=ON -DGIT_HASH="$(git rev-parse --short=7 HEAD)" -DCMAKE_BUILD_TYPE=Release -S . -B build
} else {
$VER = "${{ env.RELEASE_VERSION }}".substring(1)
cmake -DNIGHTLY_BUILD=OFF -DREL_VER=$VER -DCMAKE_BUILD_TYPE=Release -S . -B build
cmake -DNIGHTLY_BUILD=OFF -DREL_VER="$VER" -DCMAKE_BUILD_TYPE=Release -S . -B build
}
- name: Build
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
cmake -DNIGHTLY_BUILD=ON -DGIT_HASH="$(git rev-parse --short=7 HEAD)" -DCMAKE_BUILD_TYPE=Release -DQT_HOST_PATH="${{ env.QT_HOST_PATH }}" -A ARM64 -S . -B build
} else {
$VER = "${{ env.RELEASE_VERSION }}".substring(1)
cmake -DNIGHTLY_BUILD=OFF -DREL_VER=$VER -DCMAKE_BUILD_TYPE=Release -DQT_HOST_PATH="${{ env.QT_HOST_PATH }}" -A ARM64 -S . -B build
cmake -DNIGHTLY_BUILD=OFF -DREL_VER="$VER" -DCMAKE_BUILD_TYPE=Release -DQT_HOST_PATH="${{ env.QT_HOST_PATH }}" -A ARM64 -S . -B build
}
- name: Build
Expand Down

0 comments on commit 605090b

Please sign in to comment.