fix: pksetexat should update cache (OpenAtomFoundation#2736)

* fix: pksetexat should update cache * fix: handle error when expire < 0
cheniujh · Jun 17, 2024 · 4d5a9ce · 4d5a9ce
1 parent 52d92a8
commit 4d5a9ce
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/include/pika_kv.h b/include/pika_kv.h
@@ -792,6 +792,8 @@ class PKSetexAtCmd : public Cmd {
     return res;
   }
   void Do() override;
+  void DoThroughDB() override;
+  void DoUpdateCache() override;
   void Split(const HintKeys& hint_keys) override {};
   void Merge() override {};
   Cmd* Clone() override { return new PKSetexAtCmd(*this); }

diff --git a/src/pika_command.cc b/src/pika_command.cc
@@ -370,7 +370,7 @@ void InitCmdTable(CmdTable* cmd_table) {
   cmd_table->insert(std::pair<std::string, std::unique_ptr<Cmd>>(kCmdNameScanx, std::move(scanxptr)));
   ////PKSetexAtCmd
   std::unique_ptr<Cmd> pksetexatptr = std::make_unique<PKSetexAtCmd>(
-      kCmdNamePKSetexAt, 4, kCmdFlagsWrite |  kCmdFlagsKv | kCmdFlagsSlow);
+      kCmdNamePKSetexAt, 4, kCmdFlagsWrite |  kCmdFlagsKv | kCmdFlagsDoThroughDB | kCmdFlagsUpdateCache | kCmdFlagsSlow);
   cmd_table->insert(std::pair<std::string, std::unique_ptr<Cmd>>(kCmdNamePKSetexAt, std::move(pksetexatptr)));
   ////PKScanRange
   std::unique_ptr<Cmd> pkscanrangeptr = std::make_unique<PKScanRangeCmd>(

diff --git a/src/pika_kv.cc b/src/pika_kv.cc
@@ -1704,6 +1704,21 @@ void PKSetexAtCmd::Do() {
   }
 }
 
+void PKSetexAtCmd::DoThroughDB() {
+  Do();
+}
+
+void PKSetexAtCmd::DoUpdateCache() {
+  if (s_.ok()) {
+    auto expire = time_stamp_ - static_cast<int64_t>(std::time(nullptr));
+    if (expire <= 0) [[unlikely]] {
+      db_->cache()->Del({key_});
+      return;
+    }
+    db_->cache()->Setxx(key_, value_, expire);
+  }
+}
+
 void PKScanRangeCmd::DoInitial() {
   if (!CheckArg(argv_.size())) {
     res_.SetRes(CmdRes::kWrongNum, kCmdNamePKScanRange);