Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): ignore mouse up event on bond action if mouse down was not captured #1

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

targos
Copy link
Member

@targos targos commented Feb 14, 2024

The action handler requires a starting point.

…ot captured

The action handler requires a starting point.
@targos targos requested a review from lpatiny February 14, 2024 09:57
@lpatiny
Copy link
Member

lpatiny commented Feb 14, 2024

This should solve all the situations because the bug appears not only with the bond tool.

@targos
Copy link
Member Author

targos commented Feb 14, 2024

I think I tried all the tools with the fix. Can you give a repro without a bond tool?

@targos
Copy link
Member Author

targos commented Feb 19, 2024

Ping @lpatiny

@targos targos merged commit b3b2157 into main Feb 22, 2024
6 checks passed
@targos targos deleted the fix-editor-error branch February 22, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants